libinput has two types of coordinates - device coordinates and coordinates normalized into the 1000 dpi default. we generally use int/double for those two, but it's not always clear or obvious which type of coordinates we're dealing with. So there's a risk of mixing them up and we may not notice for a while (see 38ee for example where we used a threshold in device-specific coordinates).
typedefs help with readability but the compiler won't catch it. this patchset uses two different structs for the x/y pairs (which is what we're mostly concerned with). It reads a bit clunkier but we get the benefit of immediately knowing what coordinates we're dealing with. I'm somewhat in two minds about it, I like the type-safety, not a fan of the extra clunkyness. Any suggestions for improvements appreciated. Cheers, Peter _______________________________________________ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel