On Mon, 2016-01-11 at 12:04 -0600, Derek Foreman wrote: > On 11/01/16 09:41 AM, Bob Ham wrote:
> > + weston_config_section_get_bool(section, > > + "zap", &zap, true); > > I think "allow_zap" would be better... Ack > > + if (shell->zap != false) > > Wouldn't it be easier to read as > if (shell->zap) ? Yes, and I ordinarily would but I've seen style guides that forbid shortcuts like that so I was erring on the side of caution. > Otherwise looks good to me: > Reviewed-by: Derek Foreman <[email protected]> Thanks. -- Bob Ham <[email protected]> Software Engineer >>>>>>>> Open First Collabora is hiring! Please check out our latest opportunities here: http://bit.ly/Collabora-Careers <<<<<<<< _______________________________________________ wayland-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/wayland-devel
