> On Apr 5, 2016, at 3:52 AM, Pekka Paalanen <ppaala...@gmail.com> wrote: > > On Mon, 4 Apr 2016 17:55:29 -0500 > Yong Bakos <j...@humanoriented.com> wrote: > >>> Date: Sun, 3 Apr 2016 01:47:43 +0100 >>> From: Eric Engestrom <e...@engestrom.ch> >>> To: wayland-devel@lists.freedesktop.org >>> Cc: Eric Engestrom <e...@engestrom.ch> >>> Subject: [PATCH libinput] fix spelling mistakes >>> Message-ID: <1459644463-5419-1-git-send-email-e...@engestrom.ch> >>> >>> Signed-off-by: Eric Engestrom <e...@engestrom.ch> >>> --- >>> doc/t440-support.dox | 2 +- >>> src/evdev-tablet.c | 2 +- >>> src/evdev.c | 2 +- >>> src/filter.c | 2 +- >>> src/libinput.h | 8 ++++---- >>> 5 files changed, 8 insertions(+), 8 deletions(-) >>> > >> >> Looks good, thanks. (Note that I am a novice reviewer.) > > Hi Yong, > > thank you for participating! > > When you review things, you should include a line like this: > > Reviewed-by: Real Name <my@email.address> > > People pushing patches upstream will collect that and make it part of > the commit message, like this: > https://cgit.freedesktop.org/wayland/weston/commit/?id=273874e3c715a7102add0030f200d0a0f17628fa
Got it, thank you. I've added this short instruction to wayland-web/reviewing.html and will send the patch shortly. > We also use Acked-by when a particular person accepts the change in > principle, but has not properly reviewed the changes. This is usually > when that person's acceptance is important somehow. > > Btw. your recent review emails do not appear as replies to the patch > emails. This makes matching them to the particular (revision of) the > patch quite hard. It's my fault due to trying to reconstruct the original emails from the digests I receive, and I noticed this when seeing my unthreaded replies on the list archive. Don't laugh! :) I've since switched to normal emails rather than the digest. Of course, I can't receive the original PATCH emails, but assuming that replies are matched by accurate subject lines, would you like me to correct and re-send? (Let's please do what's easiest for you / others.) yong > > Thanks, > pq _______________________________________________ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel
