Hi
> > + keyboard->grab_serial = wl_display_get_serial(compositor->wl_display);
> > if (state == WL_KEYBOARD_KEY_STATE_PRESSED) {
> > - keyboard->grab_serial =
> > - wl_display_get_serial(compositor->wl_display);
> > keyboard->grab_time = time;
> > keyboard->grab_key = key;
> > }
> >
>
> I’m ok with that, but why not updating all three "grab_*" members?
While I think the key itself would be OK, I suspect updating the grab_time on
all states (ie like key release) might have additional side effects.
So I took the most conservative approach which was to update the serial only,
as this one is compared against the popup serial.
Cheers,
Olivier
_______________________________________________
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel
