On Fri, Sep 16, 2016 at 03:37:37PM -0700, Yong Bakos wrote:
> From: Yong Bakos <yba...@humanoriented.com>
> 
> Explicitly set the data member to NULL during wl_array_release, preventing the
> dangling pointer but, more importantly, making it testable.
> 
> Signed-off-by: Yong Bakos <yba...@humanoriented.com>
> ---
>  src/wayland-util.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/wayland-util.c b/src/wayland-util.c
> index 639ccf8..2efb133 100644
> --- a/src/wayland-util.c
> +++ b/src/wayland-util.c
> @@ -102,6 +102,7 @@ WL_EXPORT void
>  wl_array_release(struct wl_array *array)
>  {
>       free(array->data);
> +     array->data = NULL;

If we add
        array->size = 0;
        array->alloc = 0;

we can then remove this comment from patch #1, right?
        \note Leaves the array in an invalid state.

The series is good anyway, so it is:
Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com>

>  }
>  
>  WL_EXPORT void *
> -- 
> 2.7.2
_______________________________________________
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel

Reply via email to