On 07.10.2016 11:58, Pekka Paalanen wrote: > On Fri, 30 Sep 2016 23:25:28 +0200 > Armin Krezović <[email protected]> wrote: > >> This moves current output positioning code and scale/transform >> application to the compositor itself, so the compositor >> can configure output layouts any way it wants. >> >> A helper function for setting x and y coordinates is also >> added, and couple of assertions to weston_output_enable() >> as well, to make sure everything has been set up. >> >> Signed-off-by: Armin Krezović <[email protected]> >> --- >> compositor/main.c | 26 ++++++++++++++++++++++++++ >> libweston/compositor.c | 40 ++++++++++++++++++++++------------------ >> libweston/compositor.h | 3 +++ >> 3 files changed, 51 insertions(+), 18 deletions(-) > > Hi, > > moving the output positioning out from libweston and into the > compositor is very good. The setter for x,y is good too. > > I'm just not sure we should assume that outputs cannot occupy the > negative coordinates. If one hotplugs an output to the left, I'd assume > the existing windows would stay put on the right. If we cannot use > negative coordinates, everything has to be moved to keep them at the > same position from the user point of view. > > > Thanks, > pq >
Hi, I'd rather go for the second approach - move everything to the output it was on, in case an output gets attached on the left of an output that had something displayed (weston_output_move() can be easily adapted). Thanks, Armin.
signature.asc
Description: OpenPGP digital signature
_______________________________________________ wayland-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/wayland-devel
