On 21 November 2016 at 20:07, Daniel Stone <dan...@fooishbar.org> wrote:
> On 17 November 2016 at 11:55, Varad Gautam <varadgau...@gmail.com> wrote:
>> +static bool
>> +gl_renderer_query_dmabuf_modifiers(struct weston_compositor *wc, int format,
>> + uint64_t **modifiers,
>> + int *num_modifiers)
>> +{
>> + struct gl_renderer *gr = get_renderer(wc);
>> + int num;
>> +
>> + assert(gr->has_dmabuf_import);
>> +
>> + if (!gr->has_dmabuf_import_modifiers ||
>> + !gr->query_dmabuf_modifiers(gr->egl_display, format, 0, NULL,
>> + NULL, &num)) {
>
> The test can just be removed here, as there's none for query_dmabuf_formats.
Sorry, I can't read, and it's the other way around:
query_dmabuf_formats needs a check here, and also the
eglGetProcAddress should be moved under the same if
(EGL_EXT_...modifiers) branch as the GetProcAddress for the modifier
query.
Cheers,
Daniel
_______________________________________________
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel
