Hi Fabien, On 2 January 2017 at 16:42, Fabien Dessenne <[email protected]> wrote: > @@ -2210,9 +2210,12 @@ drm_output_choose_initial_mode(struct drm_backend > *backend, > drmModeModeInfo drm_modeline; > int32_t width = 0; > int32_t height = 0; > + uint32_t refresh = 0; > + int n; > > if (mode == WESTON_DRM_BACKEND_OUTPUT_PREFERRED && modeline) { > - if (sscanf(modeline, "%dx%d", &width, &height) != 2) { > + n = sscanf(modeline, "%dx%d-%d", &width, &height, &refresh); > + if (n != 2 && n !=3) {
This should be 'n != 3' (space on both sides). Generally I'd just fix this up when applying since it's so trivial, but I'd like this to be changed to 'WxH@R' rather than 'WxH-R', to match the kernel. Can you please respin with these changes? With those, this is: Reviewed-by: Daniel Stone <[email protected]> Cheers, Daniel _______________________________________________ wayland-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/wayland-devel
