Peter, > On Jan 11, 2017, at 4:13 PM, Peter Hutterer <peter.hutte...@who-t.net> wrote: > > Now that we have the wheel tilt with a since attribute, we don't need a > separate test attribute anymore. Remove it to avoid confusion and make syncing > the protocol easier in the future. > > Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net>
This indeed removes the temporary, contrived `since` attribute and uses the newly-existing since attribute of the wheel_tilt enum entry as the output under test. Reviewed-by: Yong Bakos <yba...@humanoriented.com> Tested-by: Yong Bakos <yba...@humanoriented.com> yong > --- > Changes to v1: > - new in this series > > tests/data/example-client.h | 9 --------- > tests/data/example-server.h | 9 --------- > tests/data/example.xml | 2 -- > 3 files changed, 20 deletions(-) > > diff --git a/tests/data/example-client.h b/tests/data/example-client.h > index 56f9bfe..c40e361 100644 > --- a/tests/data/example-client.h > +++ b/tests/data/example-client.h > @@ -1778,16 +1778,7 @@ enum wl_data_offer_error { > * offer doesn't accept this request > */ > WL_DATA_OFFER_ERROR_INVALID_OFFER = 3, > - /** > - * test 'since' attribute parsing > - * @since 3 > - */ > - WL_DATA_OFFER_ERROR_TEST_SINCE = 4, > }; > -/** > - * @ingroup iface_wl_data_offer > - */ > -#define WL_DATA_OFFER_ERROR_TEST_SINCE_SINCE_VERSION 3 > #endif /* WL_DATA_OFFER_ERROR_ENUM */ > > /** > diff --git a/tests/data/example-server.h b/tests/data/example-server.h > index 56cc83f..adfc973 100644 > --- a/tests/data/example-server.h > +++ b/tests/data/example-server.h > @@ -1469,16 +1469,7 @@ enum wl_data_offer_error { > * offer doesn't accept this request > */ > WL_DATA_OFFER_ERROR_INVALID_OFFER = 3, > - /** > - * test 'since' attribute parsing > - * @since 3 > - */ > - WL_DATA_OFFER_ERROR_TEST_SINCE = 4, > }; > -/** > - * @ingroup iface_wl_data_offer > - */ > -#define WL_DATA_OFFER_ERROR_TEST_SINCE_SINCE_VERSION 3 > #endif /* WL_DATA_OFFER_ERROR_ENUM */ > > /** > diff --git a/tests/data/example.xml b/tests/data/example.xml > index dc625b9..29b63be 100644 > --- a/tests/data/example.xml > +++ b/tests/data/example.xml > @@ -427,8 +427,6 @@ > summary="action argument has an invalid value"/> > <entry name="invalid_offer" value="3" > summary="offer doesn't accept this request"/> > - <entry name="test_since" value="4" > - summary="test 'since' attribute parsing" since="3"/> > </enum> > > <request name="accept"> > -- > 2.9.3 > > _______________________________________________ > wayland-devel mailing list > wayland-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/wayland-devel _______________________________________________ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel