On Fri, 20 Jan 2017 06:10:38 -0800 Yong Bakos <j...@humanoriented.com> wrote:
> Peter,
>
> > On Jan 11, 2017, at 4:13 PM, Peter Hutterer <peter.hutte...@who-t.net>
> > wrote:
> >
> > These are the protocol.xml changes from:
> > 66a26aeb2a: protocol: Remove inconsistent line breaks
> > a26ed0949e: protocol: indentation fixes
> > 6a18a87727: protocol: Extend wl_touch with touchpoint shape and orientation
> >
> > and a few other, smaller ones.
> >
> > Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net>
>
> This brings the test xml files up to date for consistency, and is:
>
> Reviewed-by: Yong Bakos <yba...@humanoriented.com>
> Tested-by: Yong Bakos <yba...@humanoriented.com>
Hi,
that's odd, after this patch I see:
$ diff -u protocol/wayland.xml tests/data/example.xml
--- protocol/wayland.xml 2017-01-23 16:32:32.847221497 +0200
+++ tests/data/example.xml 2017-01-23 16:32:32.849221480 +0200
@@ -1987,7 +1987,7 @@
the vertical motion of a device is converted to scroll events while
a button is held down.
</description>
- <entry name="wheel" value="0" summary="a physical wheel" />
+ <entry name="wheel" value="0" summary="a physical wheel rotation" />
<entry name="finger" value="1" summary="finger on a touch surface" />
<entry name="continuous" value="2" summary="continuous coordinate
space"/>
</enum>
I know it hasn't ever been done before so there is no precedent, but
I'd just mention the commit sha in the commit message from which the
wayland.xml has been copied from.
Anyway, the difference is not significant, and it'll get corrected on
the next sync, so:
Reviewed-by: Pekka Paalanen <pekka.paala...@collabora.co.uk>
Thanks,
pq
> > ---
> > Changes to v1:
> > - new in this series
> >
> > tests/data/example-client.h | 112 +++++++++++++++++++--
> > tests/data/example-code.c | 12 ++-
> > tests/data/example-server.h | 51 ++++++++--
> > tests/data/example.xml | 231
> > ++++++++++++++++++++++++++------------------
> > 4 files changed, 294 insertions(+), 112 deletions(-)
pgpB4gLdOuRNr.pgp
Description: OpenPGP digital signature
_______________________________________________ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel
