On Mon, 2 May 2016 22:40:14 +0100 Emmanuel Gil Peyrot <emmanuel.pey...@collabora.com> wrote:
> This makes the code more uniform with the functions taking a > weston_output* as argument, and reduces the churn of the following > commits. > > Signed-off-by: Emmanuel Gil Peyrot <emmanuel.pey...@collabora.com> > --- > src/compositor-drm.c | 130 > ++++++++++++++++++++++++++------------------------- > 1 file changed, 67 insertions(+), 63 deletions(-) Hi, this seems it would go exactly in the opposite direction of https://cgit.freedesktop.org/wayland/weston/commit/src/compositor-drm.c?id=050c1ba7290e017358cbe5f7971f8f0ead3afbcd which explains my preference and rationale. I'm also not quite sure this actually reduces churn much for the clone mode patch. > @@ -635,7 +636,7 @@ drm_output_repaint(struct weston_output *output_base, > { > struct drm_output *output = (struct drm_output *) output_base; I wonder, if one uses both 'output_base' and 'output->base' here or in called (inlined) functions, is there a danger of violating strict aliasing rules? I suppose we don't compile libweston with optimizations that would break from that, but I'd find it maybe easier to stick with one form. Particularly when 'output_base->' does not really save line length compared to 'output->base.'. Thanks, pq
pgp9TQnhaA1w9.pgp
Description: OpenPGP digital signature
_______________________________________________ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel
