Hi, On 10 April 2017 at 13:37, Pekka Paalanen <[email protected]> wrote: > On Tue, 4 Apr 2017 17:54:36 +0100 > Daniel Stone <[email protected]> wrote: >> - struct weston_plane fb_plane; >> + /* Plane currently being directly displayed by KMS */ > > Hi, > > how about: > /* Plane for a fullscreen direct scanout view */ > or > /* Plane for a fullscreen composite bypass view */ > > The "currently" bothers me.
Mm. This suggestion is good at this point in the series, but at 'Use drm_plane for scanout plane' (26/61 in v10), scanout_plane->base is the Weston plane for a fullscreen direct-scanout view, but scanout_plane itself (weston_plane rather than drm_plane) contains the plane configuration for whatever goes to the KMS primary plane (i.e. the FB ID we would pass to drmModePageFlip). This is true when we move to plane state, where output->scanout_plane->state_cur will be the state for whatever's on the KMS primary plane. Anyway, I've changed it in this patch and then it changes later, so if you have any suggestions for what it should be when it begins to reflect the KMS primary plane state, do shout there. Cheers, Daniel _______________________________________________ wayland-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/wayland-devel
