On 12/8/17 3:13 PM, Matt Hoosier wrote:
On Fri, Dec 8, 2017 at 4:26 AM, Quentin Glidic
<sardemff7+wayl...@sardemff7.net> wrote:
On 12/8/17 11:22 AM, Quentin Glidic wrote:
From: Matt Hoosier <matt.hoos...@gmail.com>
As discussed on
https://lists.freedesktop.org/archives/wayland-devel/2017-August/034720.html,
it's useful for the shell implementation to know when these change,
for example to relay the information on to taskbars or similar.
To avoid ABI changes or the need to make the weston_desktop_surface
definition public, new functions are introduced for attaching
listeners to these signals.
Signed-off-by: Matt Hoosier <matt.hoos...@gmail.com>
Reviewed-by: Quentin Glidic <sardemff7+...@sardemff7.net>
Signed-off-by: Quentin Glidic <sardemff7+...@sardemff7.net>
---
(Err, wanted to drop the Sob send-email added via command line and I just
closed vim…)
I made this v3 to rename the signal to "metadata" instead of "title", but
also to tweak a tiny bit the signal sending. I wanted the shell not to have
to strdup() these, so now, it can listen to the signal, and compare old and
new values (and even use both) without extra cost.
Do you ack that change?
Still not sure I prefer a signal to just adding to the callbacks struct, but
we can always break API/ABI again later if we need to. :-)
I like the change, and prefer the name "metadata" for the signal
anyway. The v3 changes are:
Acked-by: Matt Hoosier <matt.hoos...@gmail.com>
(Not sure whether you actually want to put it into the commit message,
since I'm the original author. But I approve.)
Thanks for the review.
It was just a matter of making sure you understand the change. :-)
And finally, pushed !
037f056ec..555c548c7 master -> master
Thanks,
--
Quentin “Sardem FF7” Glidic
_______________________________________________
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel
