Hi,
On 16 January 2018 at 08:25, Pekka Paalanen <ppaala...@gmail.com> wrote:
> On Wed, 20 Dec 2017 12:26:22 +0000
> Daniel Stone <dani...@collabora.com> wrote:
>> + switch (type) {
>> + case WDRM_PLANE_TYPE_CURSOR:
>> + format = GBM_FORMAT_ARGB8888;
>> + break;
>> + case WDRM_PLANE_TYPE_PRIMARY:
>> + format = output->gbm_format;
>
> It seems output->gbm_format is not yet set at this time, so it cannot
> be used here. However, this is fixed in the next patch, and before that
> this code path is not reached, so technically it's ok.
Very right. I think the easiest thing to do is to just delete the
PRIMARY case here - always falling through to an assert - and only
handle it in the next patch.
Cheers,
Daniel
_______________________________________________
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel
