On Mon, 12 Feb 2018 12:26:50 +0000
Daniel Stone <dan...@fooishbar.org> wrote:

> Hi Pekka,
> 
> On 9 February 2018 at 13:07, Pekka Paalanen <ppaala...@gmail.com> wrote:
> > Let drm_output_enable() remove the CRTC and the connector from the
> > unused id arrays.
> >
> > In the future when a list of drm_heads supersedes unused_connectors
> > array, the usedness of a connector will be determined by the enabled
> > state of the output the connector (head) is attached to. The enabled
> > state is turned on by drm_output_enable(). If unused_crtcs array was
> > still updated in drm_output_repaint(), the CRTC and connector usedness
> > would be tracked in different places. Logically the two belong together.  
> 
> I agree that when we have heads/connectors, this is logically the
> right thing to do. This patch does reflexively make me a little uneasy
> though: it relies on the repaint loop successfully completing before
> the next repaint flush. The reason I moved the unused ID removal to
> the bottom of repaint, is because that's the first point at which we
> know (within reason) that repaint will succeed.
> 
> On the other hand, if repaint fails the output pretty much just wedges
> forever anyway. So even though I'm kind of wary of this first one and
> get the feeling we might end up revisiting it, I don't think it makes
> things worse, and hopefully clone-mode makes it completely obsolete
> anyway.
> 
> Bar a couple of minor nitpicks, series is:
> Reviewed-by: Daniel Stone <dani...@collabora.com>
> 
> Cheers,
> Daniel

Thank you for the reviews. Pushed with comments addressed:
   c1bcce6a..5b0aa55d  master -> master


Thanks,
pq

Attachment: pgpJdi3lZ4Ipc.pgp
Description: OpenPGP digital signature

_______________________________________________
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel

Reply via email to