On Sun, Feb 18, 2018 at 01:09:22PM +0300, Konstantin Kharlamov wrote:
> For the purposes it seems to work fine — it's marked RFC because I see a
> small oddness, and I think it's better to ask someone more
> acknowledgable in libinput codebase.

thanks, much appreciated. I was hoping I get to this today but didn't, I'll
try for it tomorrow. meanwhile:

> 
> For some reason every time I run 
> 
>       libinput debug-events --verbose | grep bled
> 
> I see a message about hysteresis being enabled, which then never appears
> until I stop the command, and re-run it again. It looks like every time
> the command ran, touchpad being reinitialized, making the function
> tp_init_hysteresis() to ran again.
 
it's expected, yes. debug-events instantiates a new libinput context (you
can't get to the one in the compositor) and your code, from a quick glance,
only runs until enabled. so every time you start the tool, you start from
zero.

Cheers,
   Peter

> If this is an intentional behavior, then I have no other question, and
> the patchset should be fine. Though it would be nice if someone with a
> "non-wobbly" touchpad could test that it does not enable hysteresis for
> them (it all should be good, but testing never hurts :)
>
> 
> P.S.: I don't have commit rights.
> 
> Konstantin Kharlamov (2):
>   touchpad: remove the code for disabling hysteresis
>   touchpad: add wobbling detection
> 
>  src/evdev-mt-touchpad.c | 42 ++++++++++++++++++++++++++++--------------
>  src/evdev-mt-touchpad.h |  1 +
>  2 files changed, 29 insertions(+), 14 deletions(-)
> 
> -- 
> 2.15.1
> 
> _______________________________________________
> wayland-devel mailing list
> wayland-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/wayland-devel
> 
_______________________________________________
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel

Reply via email to