Hi Pekka,

All your patches are reviewed by me:
Reviewed-by: Emre Ucan <[email protected]>

Don't relying on build directory has the major advantage that it is lot easier 
to run weston unit-tests in target environment if weston is cross compiled.

Best regards

Emre Ucan
Engineering Software Base (ADITG/ESB)

Tel. +49 5121 49 6937

> -----Original Message-----
> From: wayland-devel [mailto:wayland-devel-
> [email protected]] On Behalf Of Pekka Paalanen
> Sent: Montag, 18. Juni 2018 16:41
> To: [email protected]
> Cc: Pekka Paalanen <[email protected]>
> Subject: [PATCH weston 0/4] Preparing for Meson
> 
> From: Pekka Paalanen <[email protected]>
> 
> Hi,
> 
> these changes are intended to make using Meson easier. Daniel's patches
> are v2, mine are v1.
> 
> 
> Daniel Stone (2):
>   tests: Don't rely on build directory layout
>   tests: Reshuffle IVI layout tests
> 
> Pekka Paalanen (2):
>   shared: remove weston_config_get_libexec_dir()
>   tests: remove WESTON_BUILD_DIR from env
> 
>  Makefile.am                                        | 16 +++---
>  compositor/main.c                                  | 25 +++++++---
>  compositor/text-backend.c                          |  6 +--
>  compositor/weston-screenshooter.c                  |  8 ++-
>  compositor/weston.h                                |  3 ++
>  desktop-shell/shell.c                              |  9 +---
>  ivi-shell/hmi-controller.c                         | 12 ++++-
>  ivi-shell/weston.ini.in                            |  8 +--
>  libweston/compositor.c                             | 57 
> ++++++++++++++++++++--
>  libweston/compositor.h                             |  3 ++
>  shared/config-parser.c                             | 12 -----
>  shared/config-parser.h                             |  2 -
>  ...-internal-test.c => ivi-layout-internal-test.c} |  0
>  ...{ivi_layout-test.c => ivi-layout-test-client.c} |  8 +--
>  ...yout-test-plugin.c => ivi-layout-test-plugin.c} | 26 +++++-----
>  tests/weston-tests-env                             | 21 ++++++--
>  16 files changed, 140 insertions(+), 76 deletions(-)
>  rename tests/{ivi_layout-internal-test.c => ivi-layout-internal-test.c} 
> (100%)
>  rename tests/{ivi_layout-test.c => ivi-layout-test-client.c} (97%)
>  rename tests/{ivi_layout-test-plugin.c => ivi-layout-test-plugin.c} (98%)
> 
> --
> 2.16.4
> 
> _______________________________________________
> wayland-devel mailing list
> [email protected]
> https://lists.freedesktop.org/mailman/listinfo/wayland-devel
_______________________________________________
wayland-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/wayland-devel

Reply via email to