On Fri, Sep 13, 2019 at 09:32:01AM -0400, Drew DeVault wrote: > On Thu Sep 12, 2019 at 2:42 PM Pekka Paalanen wrote: > > > This was resolved by choosing to have multiple drm_lease_manager > > > globals, one for each DRM device. No reworking should be necessary. > > > > in that case, document it in the XML please. > > ack >
If one global corresponds to a single drm device, why not call it "_device" instead of "_manager"? Usually there is only one "manager" object, and it'd be confusing to have multiple manager objects without it being clear that it's per device. Being globals it's prone to race conditions as well (I'd expect to see leasable devices to come and go, especially with eGPU's being a thing). Then again, with wl_global_remove() it's not *that* bad. The alternative is to make the _manager object an actual manager object that has 'added' and 'removed' events with the "_device" containing the actual lease request. Jonas _______________________________________________ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel
