Thanks for working on this, activation is something key that we are sorely missing.
If we want a complete 1:1 port of the X11 protocol, this certainly technically fine, other than my one minor comment. I dislike the X11 spec, so it's not my preference moving forward. The main thing I dislike is that it requires the surface releasing focus to know what it will be launching. Especially with flatpal + xdg portal we're increasingly going to be to want to pass focus without knowing to whom. Similarly, dbus activation on a common name such as filemanager1 could be to any app. The other thing I've had a problem with is that historically we have a lot of problems with apps not clearing their startup notifications. This was especially true of apps that immediately dock to the status icon, something this spec would have a problem with, unless we allow nulls to the acknowledge request. IMHO we can get something cleaner if we treat it as two independent problems. * Passing focus * Startup notifications One is conceptually passing data from surface-> surface The other is passing data app -> the shell There's some overlap, but not a lot. Personally I would also like to see set_activation_token(string, seat, serial) and activate(string) be methods on xdg_toplevel, partly because they're so integral to everyday operation, partly because it's the only surface type we want to activate. David _______________________________________________ wayland-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/wayland-devel
