On Tuesday, April 15th, 2025 at 13:12, Borah, Chaitanya Kumar <chaitanya.kumar.bo...@intel.com> wrote:
> On 4/8/2025 10:10 PM, Daniel Stone wrote: > > > As it stands, I've gone through the implementation pretty thoroughly, > > as well as our use of it in Weston. I'm happy with how it looks for > > pre-blend, and I'm even happier that the implementation is written to > > apply easily to apply to post-blend CRTC pipelines. > > Since we are planning to use this frame work on post-blend pipelines > eventually. Should we change the name space of the current pre-blend > helpers to reflect that? > > e.g. > > s/drm_colorop_curve_1d_lut_init/drm_plane_colorop_curve_1d_lut_init/ > s/drm_colorop_3dlut_init/drm_plane_colorop_3dlut_init/ No objections against that, but I'd also be fine with keeping the current names because it's not yet clear how these functions will be adapted for post-blending. Maybe the functions will be re-used and the plane argument dropped, in which case it'd make more sense to keep the current name. We don't know yet.
