Le 18/09/2025 à 02:43, Nícolas F. R. A. Prado a écrit :
In order to allow for post-blend color pipelines, colorops need to be assigned to a crtc rather than a plane. Add a crtc to the colorop struct to enable this. Either the plane or the crtc will be set for any given colorop depending on whether it is part of a pre- or post-blend color pipeline. Signed-off-by: Nícolas F. R. A. Prado <[email protected]> --- include/drm/drm_colorop.h | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/include/drm/drm_colorop.h b/include/drm/drm_colorop.h index d61c6c40e47162cb8b1e7db58b6746c43ac5d202..7a4e0d0c4a3d594abecef304b1d5990434cdb231 100644 --- a/include/drm/drm_colorop.h +++ b/include/drm/drm_colorop.h @@ -206,10 +206,16 @@ struct drm_colorop { /** * @plane: * - * The plane on which the colorop sits. A drm_colorop is always unique - * to a plane. + * The plane on which the colorop sits if it is a pre-blend colorop. + * In this case it is unique to the plane. + * + * @crtc: + * + * The CRTC on which the colorop sits if it is a post-blend colorop. + * In this case it is unique to the CRTC. */
If there is a v3 of this series, I think it could be nice to have something like "plane and CRTC are mutually exclusive".
With or without this: Reviewed-by: Louis Chauvet <[email protected]>
struct drm_plane *plane; + struct drm_crtc *crtc;/*** @state:
-- -- Louis Chauvet, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
