Hi all,

I've been having a problem with email addresses that contain a plus "+", which we use for cyrus plus addressing to deliver direct to shared mail folders.

I can add aliases with a destination containing a plus but I cannot delete them. I have made the quick hack of making the destination encoded so the GET can get through to the next page. It seems this only happens between different actions (i.e. whilst passing from editalias to deletealias).

I'm no php guru by any means so I'm sure there's going to be a better way of doing this. e.g passing all variables from GET via urlencode on transitions between pages, perhaps in validate.php?

Here's my diff

--- web-cyradm-trunk/editalias.php      2006-10-02 04:05:09.000000000 +0100
+++ web-cyradm-trunk-new/editalias.php  2006-10-02 23:36:38.890596304 +0100
@@ -75,7 +75,7 @@
                        if ($row['username'] != $_GET['domain']) {
                                $action = _("Cannot remove from account");
                        } else {
- $action = '<a href="index.php?action=deletealias&domain='.$_GET['domain'].'&alias='.$_GET['alias'].'&dest='.$row['dest'].'">'. _("Remove destination").'</a>'; + $action = '<a href="index.php?action=deletealias&domain='.$_GET['domain'].'&alias='.$_GET['alias'].'&dest='.urlencode($row['dest']).'">'. _("Remove destination").'</a>';
                        }
 ?>
                        <tr class="<?php echo $cssrow; ?>">

Cheers,

Matt

_______________________________________________
This mailing list is hosted and supported
by bit-heads GmbH | http://www.bit-heads.ch

_______________________________________________
Web-cyradm mailing list
[email protected]
http://www.web-cyradm.org/mailman/listinfo/web-cyradm

Reply via email to