I agree. In trunk. they both unlock but session.forget(response) does not save the session. session._unlock(response) instead still saves the session when the request is completed.
On Tuesday, 5 February 2013 12:33:03 UTC-6, Paolo valleri wrote: > > Niphlod has written exactly what I have in mind. > Given the fact that distinct requests from the same user/session are > serialized as Massimo has outlined from my point of view we should add > session.forget() or session._unlock(request) as early as possible in the > download() function of globals.py > @Massimo, which are the difference between session.forget(request) and > session._unlock(request)? Which one is the better to use in this case? > > Paolo > > > 2013/2/5 Niphlod <[email protected] <javascript:>> > >> >> >> On Tuesday, February 5, 2013 5:30:11 PM UTC+1, Massimo Di Pierro wrote: >>> >>> Not sure I understand the question. >> >> >> I think the doubt lies into the fact that given 1 request for the wiki >> page and ,e.g., 4 requests for 4 embedded images the 5 requests would be >> concurrent or serialized. In my apps whenever I don't use session I put at >> the top a session.forget(), and I know for a fact that static files are >> handled concurrently (they are outside session logic in main.py). >> >> In theory to download something (either in the default download() or in >> the catch of the wiki) session is not touched, so in case the requests are >> in fact serialized a session.forget() could/should be added. >> >> >> -- >> >> --- >> You received this message because you are subscribed to the Google Groups >> "web2py-users" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected] <javascript:>. >> For more options, visit https://groups.google.com/groups/opt_out. >> >> >> > > -- --- You received this message because you are subscribed to the Google Groups "web2py-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
