[web2py] PATCH: updates to browserid_account.py

[Holger Schurig]

1. browserid.org changed into login.persona.org, both URLs and issues. The 
old URL continues to work, but it might be better to use the new ones 
anyway.

2. the plugin did redirecto to http://google.com (Huh?!?!) even when 
"on_login_failure" was set

3. if on_login_failure wasn't set, it redirected to http://google.com, I 
now changed that it now redirects to login.persona.org


I ponder the idea if I change the plugin further, so that on_login_failure 
is a mandatory parameter when creating the BrowserID class instance. Also, 
there is currently no error reportion possible, i.e. the end-user will 
never see if the expiration date was wrong, the issuer was wrong etc. Maybe 
the kind of error should be sent somehow with the redirect?  (I'm still 
very new in web2py and don't exactly know how that could happen ...).

-- 

--- 
You received this message because you are subscribed to the Google Groups 
"web2py-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to web2py+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.



Index: web2py/gluon/contrib/login_methods/browserid_account.py
===================================================================
--- web2py.orig/gluon/contrib/login_methods/browserid_account.py	2013-06-18 15:30:29.370167306 +0200
+++ web2py/gluon/contrib/login_methods/browserid_account.py	2013-06-18 15:38:50.985756682 +0200
@@ -9,7 +9,7 @@
 
     thanks and credits to the web2py community
 
-    This custom authenticator allows web2py to authenticate using browserid (https://browserid.org/)
+    This custom authenticator allows web2py to authenticate using browserid (https://login.persona.org/)
     BrowserID is a project by Mozilla Labs (http://mozillalabs.com/)
     to Know how browserid works please visit http://identity.mozilla.com/post/7616727542/introducing-browserid-a-better-way-to-sign-in
 
@@ -39,10 +39,10 @@ class BrowserID(object):
                  audience="",
                  assertion_post_url="",
                  prompt="BrowserID Login",
-                 issuer="browserid.org",
-                 verify_url="https://browserid.org/verify";,
-                 browserid_js="https://browserid.org/include.js";,
-                 browserid_button="https://browserid.org/i/sign_in_red.png";,
+                 issuer="login.persona.org",
+                 verify_url="https://login.persona.org/verify";,
+                 browserid_js="https://login.persona.org/include.js";,
+                 browserid_button="https://login.persona.org/i/sign_in_red.png";,
                  crypto_js="https://crypto-js.googlecode.com/files/2.2.0-crypto-md5.js";,
                  on_login_failure=None,
                  ):
@@ -76,9 +76,13 @@ class BrowserID(object):
             if j["status"] == "okay" and j["audience"] == audience and j['issuer'] == issuer and j['expires'] >= epoch_time:
                 return dict(email=j['email'])
             elif self.on_login_failure:
-                redirect('http://google.com')
+                #print "status:  ", j["status"]=="okay", j["status"]
+                #print "audience:", j["audience"]==audience, j["audience"], audience
+                #print "issuer:  ", j["issuer"]==issuer, j["issuer"], issuer
+                #print "expires:  ", j["expires"] >= epoch_time, j["expires"], epoch_time
+                redirect(self.on_login_failure)
             else:
-                redirect('http://google.com')
+                redirect('https://login.persona.org')
         return None
 
     def login_form(self):