We speak about that few days ago here: https://groups.google.com/forum/m/#!topic/web2py-developers/DvRqziEe_GE El sep 27, 2013 2:28 PM, "Michele Comitini" <[email protected]> escribió:
> Massimo, Niphlod > can we add those instructions to the book? A chapter "Contributing to > web2py" can be helpful, don't you think? > > > > 2013/9/27 Niphlod <[email protected]> > >> in addition to joining the developers group, there are some (absolutely >> not required, but good to have) main ideas to follow (it's how currently >> most of contributors are dealing with PR): >> - github is preferred for their PR system >> - make your patch on a topic branch against current master trunk >> - it should be a patch that can be fast-forwarded (i.e. merged >> automatically in current master) >> - composed of a single commit (unless the patch is long and needs >> specific commit "comments" to track it later) >> - commit message **should** include a "thanks to @someone" if it was >> someone else that pointed out the bug or raised the request for the feature >> - if the commit contains a new feature it should come with the relative >> tests (unittest in gluon/tests) >> >> I have another one, but it seems that I'm the only one (would be good if >> we agree on something consistent): >> - every bug-fixing commit should come from a branch named >> "issue/number_of_the_issue_on_google_code" (like issue/1684) >> - every enhancement commit should come in a branch named >> "enhancement/title_of_the_enhancement" (like enhancement/trapped_links) >> >> >> >> >> On Friday, September 27, 2013 5:43:51 PM UTC+2, Ricardo Cárdenas wrote: >>> >>> (Apologies if this has been asked before.) >>> >>> Kudos for web2py and for this community; happy to have found you. >>> Web2py's very useful for my projects; even enjoyable! >>> >>> I'd like to pay it back, starting with minor patches that I think could >>> be useful to others. I can fork and watch on github, and generate PRs, >>> but... Is there a document with guidelines on doing so? (I don't mean >>> github instructions, more like "what you are looking for in good PRs") I >>> saw reference to an agreement that should be signed? Mailing lists one can >>> join to get the hang of etiquette and how the devs currently manage the >>> process? >>> >>> best regards -Ricardo >>> >> -- >> Resources: >> - http://web2py.com >> - http://web2py.com/book (Documentation) >> - http://github.com/web2py/web2py (Source code) >> - https://code.google.com/p/web2py/issues/list (Report Issues) >> --- >> You received this message because you are subscribed to the Google Groups >> "web2py-users" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> For more options, visit https://groups.google.com/groups/opt_out. >> > > -- > Resources: > - http://web2py.com > - http://web2py.com/book (Documentation) > - http://github.com/web2py/web2py (Source code) > - https://code.google.com/p/web2py/issues/list (Report Issues) > --- > You received this message because you are subscribed to the Google Groups > "web2py-users" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/groups/opt_out. > -- Resources: - http://web2py.com - http://web2py.com/book (Documentation) - http://github.com/web2py/web2py (Source code) - https://code.google.com/p/web2py/issues/list (Report Issues) --- You received this message because you are subscribed to the Google Groups "web2py-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
