Anthony,
i am using ver 2.16.1-stable+timestamp.2017.11.14.05.54.25
(Running on Rocket 1.2.6, Python 2.7.6)
just check the head on github and seems there are still mentions of
btn-default but also for btn-secondary for example in
new_button = INPUT(
_type="button", _value=T('New Search'), _class="btn
btn-default", _title=T('Start building a new search'),
_onclick="%s_build_query('new','%s')" % (prefix, field))
and_button = INPUT(
_type="button", _value=T('+ And'), _class="btn
btn-default", _title=T('Add this to the search as an AND term'),
_onclick="%s_build_query('and','%s')" % (prefix, field))
or_button = INPUT(
_type="button", _value=T('+ Or'), _class="btn btn-default
", _title=T('Add this to the search as an OR term'),
_onclick="%s_build_query('or','%s')" % (prefix, field))
close_button = INPUT(
_type="button", _value=T('Close'), _class="btn
btn-default",
_onclick="jQuery('#%s').slideUp()" % panel_id)
but in other cases both are referenced i.e
elif ui == 'web2py':
ui = dict(widget='',
header='',
content='',
default='',
cornerall='',
cornertop='',
cornerbottom='',
button='button btn btn-default btn-secondary',
buttontext='buttontext button',
so its not clear to me if all references should be made to both classes
Stelios
I just also realized i might be posting on the wrong group. Probably the
devs group might have been the correct one.
On Friday, July 13, 2018 at 5:23:31 PM UTC+3, Anthony wrote:
>
> I believe this is fixed in master, so you could try cloning master
> directly from Github.
>
> Anthony
>
> On Friday, July 13, 2018 at 6:25:16 AM UTC-4, Stelios Koroneos wrote:
>>
>> Greetings to all.
>> As i was working with grid i stumbled upon the same issue mention in 1929
>>
>> https://github.com/web2py/web2py/issues/1929
>>
>> The problem comes from a change in bootstrap button classes.
>> I was able to fix it in my copy by replacing all mentions of btn-default
>> and was wondering what is the "web2py way" of pushing a change like this.
>> Should all references to the now defunct btn-default class be replaces
>> with btn-secondary or add a btn-default class in the css?
>> My question has to do with the concept of not breaking backward
>> compatibility. Not sure if this applies to css also.
>>
>
--
Resources:
- http://web2py.com
- http://web2py.com/book (Documentation)
- http://github.com/web2py/web2py (Source code)
- https://code.google.com/p/web2py/issues/list (Report Issues)
---
You received this message because you are subscribed to the Google Groups
"web2py-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
