It appears mercurial code review of branches is not yet in place - http://code.google.com/p/support/issues/detail?id=2514
you can create a clone, open it for comments, and refer to an issue on the main project, but it looks like you will only have line-by-line comments; You will be missing general comments on the entire revision, and scoring: http://code.google.com/p/support/wiki/CodeReviews .... On Dec 5, 1:17 pm, Yarko Tymciurak <[email protected]> wrote: > Google Code provides a code review tool. > > Let's figure out how to use this. > > Here are the basics: > > To to the file / line you want to comment on; > double-click the line; > enter your comment. > > Here are the administrative details: > > To accept comments, a "project" (by default) allows comments by > project memebers; for web2py trunk (for example) this is Massimo, and > one other person. > > This is good. A repository (in the tab: Administer->Source) can set > comments to be public (allowed by anyone), any project member > (default), or disabled. A project can also set emailing of comments > when posted to be mailed out (for example) to a destination. > > HERE'S WHAT I SUGGEST: > > I do NOT think trunk should enable comments / code reviews in general. > > Instead, I suggest this: Create a clone; make changes as you > propose; enable review (I suggest all non-members), and announce it > on list. > > These comments can then be resolved, and - when done - suggested to > Massimo to take as a patch / merge; (no mailing needed anymore!). > > I have created google group: > web2py-code-reviewshttp://groups.google.com/group/web2py-code-reviews > > as well as a clone so everyone can play around with posting some > comments, and watching them appear in the > group:http://code.google.com/r/yarkot1-code-review-test/ > > Only reviews are allowed to post to the group; > You can monitor reviews by monitoring this group; > To add a review, have a manager add your review email to the group > (and set it to allow posts), then have review comments sent to web2py- > [email protected] > > If this test doesn't work out, or someone has better ideas, we'll > change / modify; if it works, I'll add the web2py admins as admins on > web2py-code-reviews (so they can add reviews). No one should post to > this group (other than the review / clone). > > TO GET FAMILIAR WITH POSTING COMMENTS / ETC. PARTICIPATE IN A TEST: > > I have made a clone and enabled reviews, so anyone can try this out. > I encourage you to try anything, just so we can work the process > out. If you have a _real_ comment, you might want to remember it to > post for a _real_ review (or sent it separately). > > Eventually, we can add a web2py function and try out Post-Commit hooks > (URL), and figure out how this integrates with the Issue Tracker on > google code (I don't know how issues from the main web2py will link > into clones; lets see...). > > Let's see how this goes. > > - Yarko -- You received this message because you are subscribed to the Google Groups "web2py-users" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/web2py?hl=en.
