On Feb 2, 2010, at 1:19 PM, Thadeus Burgess wrote:
> 1. Its only in two places. Once for tablename, and once for fieldname.
> And then this needs to be done for sql.py just in case
DRY
>
> 2. Yes very chatty. What about the following?
>
> DAL('sqlite....', pool_size=1, check_reserve=None)
> DAL('sqlite....', pool_size=1, check_reserve='common')
> DAL('sqlite....', pool_size=1, check_reserve='all')
> DAL('sqlite....', pool_size=1, check_reserve='postgres')
> DAL('sqlite....', pool_size=1, check_reserve='mssql')
>
> This way we can define the level of check. Then the check will be
> placed in a function of db. db._verify_reserved_keyword(keyword) which
> will perform the checks based on the self.check_reserve.
> None would be no name checking, to keep backwards compatibility and
> for production systems. comments?
Makes sense. How about accepting a list?
>
> 3. How is it ambiguous, you hit the definition right on target. Its
> common SQL commands that without these commands you don't have SQL,
> and if you use one of these terms in the current system you get an
> OperationalError anyways.
OK...
--
You received this message because you are subscribed to the Google Groups
"web2py-users" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/web2py?hl=en.
