Thanks Iceberg, I did not see this when I originally coded it but you are right!

I sent a patch to Massimo.

-Thadeus





On Fri, Feb 26, 2010 at 8:07 PM, Iceberg <[email protected]> wrote:
> Recent web2py contains a cache statistics page in appadmin. That is
> good!
>
> But so far, the total Hit Ratio is calculated as:
>  total['ratio'] = (ram['ratio'] + disk['ratio']) / 2
>
> that doesn't feel right. Think about that when a scenario only uses
> cache.ram or only uses cache.disk, then the total ratio is just half
> of the actual value! Doesn't make sense.
>
> Should change to:
>    try:
>        total['ratio'] = total['hits'] * 100 / (total['hits'] +
> total['misses'])
>    except:
>        total['ratio'] = 0
>
>
> Regards,
> Iceberg
>
> --
> You received this message because you are subscribed to the Google Groups 
> "web2py-users" group.
> To post to this group, send email to [email protected].
> To unsubscribe from this group, send email to 
> [email protected].
> For more options, visit this group at 
> http://groups.google.com/group/web2py?hl=en.
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"web2py-users" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/web2py?hl=en.

Reply via email to