On Aug 20, 2010, at 8:29 AM, mdipierro wrote: > I changed and changed back. I am waiting for comments form other > developers. I am not sure what the best course of action is.
What's an example of the framework breakage using the helper form of URL? > > Massimo > > On Aug 20, 8:23 am, Phyo Arkar <[email protected]> wrote: >> So the way it worked before was a bug and now (rev 853) it is a feature? >> >> On 8/20/10, mdipierro <[email protected]> wrote: >> >>> On a second thought we should leave it alone. Else we break the >>> scaffolding app, i.e. 90% os apps out there.. Anyway,... I'd still >>> like to hear your opinions. >> >>> On Aug 19, 8:38 pm, mdipierro <[email protected]> wrote: >>>> There is a problem (in 1.83.2 and earlier version) >> >>>> URL(....) >> >>>> returns a string, not a helper. If you want to include the string >>>> without escaping twice you have to do >> >>>> {{=XML(URL(...))}} >> >>>> In trunk, I modified the definition of URL so that it returns the >>>> XML(..) helper wrapping the string. This will prevent >> >>>> {{=URL(...)}} >> >>>> from double escaping but will prevent you from doing >> >>>> 'http://127.0.0.:8000'+URL(..) >> >>>> you would have to do >> >>>> 'http://127.0.0.:8000%s'%URL(..) >> >>>> we cannot have it both ways. >> >>>> URL is either a helper or a string... The more I think about it the >>>> more I am convinced URL should be a helper not a string otherwise all >>>> the examples in which we use {{=URL(...)}} are buggy. Therefore this >>>> change should be considered a bug fix and not a breaking of backward >>>> compatibility. >> >>>> What do other people think? Should we change this as in trunk or leave >>>> it alone? >> >>>> Massimo >> >>>> On Aug 19, 1:39 pm, Phyo Arkar <[email protected]> wrote: >> >>>>> Trunk version Rev 853 >> >>>>> in view: >>>>> $("#list").jqGrid({ >> >>>>> url:"{{=URL(r=request,f='listMIME.json',vars={'extracted_path':extracted_path,'source_path':source_path})}}", >> >>>>> HTML Result: >>>>> $("#list").jqGrid({ >>>>> url:"/sExtract/extraction/listMIME.json?source_path=home*&* >>>>> ;extracted_path=target", >> >>>>> it insert &instead of & >> >>>>> that screwed up all my sites :D .. >> >>>>> have not tested with released version ..
