On 05-10-2010 01:10, Mariano Reingart wrote:
> Hi, attached is a PostgreSQL enhanced versión of Alexandre Andrade mysql 
> script.
>
> It uses information_schema (ANSI Standard), so it might support others
> databases too.
> It connects to live databases (doesn't need SQL dump), and supports:
> keyed tables, most data types, default values, constraints (unique/not
> null/referential fk) and comments.
>
Is it not necessary to put "cur.close() before return succesfull ?
cheers,
Stef

def query(conn, sql,*args):
    "Execute a SQL query and return rows as a list of dicts"
    cur = conn.cursor()
    ret = []
    try:
        if DEBUG: print >> sys.stderr, "QUERY: ", sql % args
        cur.execute(sql, args)
        for row in cur:
            dic = {}
            for i, value in enumerate(row):
                field = cur.description[i][0]
                dic[field] = value
            if DEBUG: print >> sys.stderr, "RET: ", dic
            ret.append(dic)
cur.close () ??
        return ret
    finally:
        cur.close()


Reply via email to