On Nov 3, 2010, at 6:12 AM, Martín Mulone wrote: > Online new version: > > http://web2pytesting.appspot.com/
Nice and simple. With all that room at the top, though, it'd be nice if the flash didn't obscure the top-right navigation links. > > > > 2010/11/3 Martín Mulone <[email protected]> > - removed the tests (because make it un-necessarily heavy) > > Why do you think is heavy, yes there are new things, but none of them is > loaded, only loaded by controller test. And test can be removed without > affecting anything. The test are for a web developer, perhaps i don't explain > what the meaning of each test. Perhaps you can keep only test elements I > think this is important for a web developer. And test layout is a guide of > using sidebars. > > - removed jgrowl > > I put jgrowl because is a way better than the default one, can be customize, > and have and little important thing has a close button. > > - moved the ok, warn, error login into the controller > > ok > > - moved the left_sidebar_enabled and right_sidebar_enabled logic into > layout.html > > I put it on view following what you said about the user can have different > sidebars depending of the view. Your logic is right. > > - renamed noti_ok.png to ok.png (same for error and warn). > > Ok > > -Now we have a minor problem... > This breaks all layouts (web2py.com/layouts) and the wizard. > > I forget to test layout. But yes its gonna break some things. But I dont > think, hard to fix. > > -They all assume superfish.js is in the static/ folder but now it is in > static/js/superfish.js > I put a new version of superfish, preserving the original package of the > developers, this is important, because when you are going to update to a new > version, you only have to overwrite files, and you don't have to edit > manually base.css. the same to jgrowl, and others third party javascript. > > I think this is scaffold application, are for new application, how many > people are going to update your apps to the new layout?. For me I think 0. A > Good practice tell me that need the organization on static, put all the files > in one dir sorry but it is not for me. We have in time to star doing this. > What i propose is simple: 3 directorys as a base: > > static/css/ > static/images/ > static/js/ > > Supossed I have a bit complex with others third party js. > > static/css/jgrowl/jgrowl.css > static/images/jgrwol/somelogo.png > static/js/jgrowl/jgrowl.js > > All the css when refering to an image instead of doing url('myimage.png') has > to be change to url('../image/myimage.png') > > Perhaps some modification in admin, you can do a new button that let the user > to start new application, called new layout, and option for legacy. > > 2010/11/3 mdipierro <[email protected]> > > The new welcome app proposed by Martin (in HTML5) is in trunk. > > Excellent job Martin. > > I made some changes: > - removed the tests (because make it un-necessarily heavy) > - removed jgrowl > - moved the ok, warn, error login into the controller > - moved the left_sidebar_enabled and right_sidebar_enabled logic into > layout.html > - moved the flash back to the top-right corner > - renamed noti_ok.png to ok.png (same for error and warn). > > Now we have a minor problem... > This breaks all layouts (web2py.com/layouts) and the wizard. > They all assume superfish.js is in the static/ folder but now it is in > static/js/superfish.js > > We have two solutions: > 1) change all layouts w2p files to look for superfish in static/ or in > static/js > 2) move all the current static files in static/ and our of static/css, > static/js, static/images/. > > Probably 1) is a better option. > > Massimo > > > > > -- > My blog: http://martin.tecnodoc.com.ar > My portfolio *spanish*: http://www.tecnodoc.com.ar > Checkout my last proyect instant-press: http://www.instant2press.com > > >
