[web2py] extract get_records from build_set in IS_IN_DB

[Carlos]

Hi Massimo,

I need some special cases for IS_IN_DB where I directly provide the 
records/rows, instead of selecting them via dbset.

For this reason I was wondering if it's possible that you extract the 
records building part from build_set method in IS_IN_DB class into the 
following new get_records?:

    def *get_records*(self, fields):
        if self.dbset.db._dbname != 'gae':
            ...
            records = ...
        else:
            ...
            records = ...
        return records

    def *build_set*(self):
        ... (calculate fields)
        records = self.get_records(fields)
        ... (calculate theset and labels)

This has no repercusion whatsoever, except that it makes this class easier 
to subclass without repeating code.

I know I can subclass it without you making any changes and override/extend 
build_set method, but I would have to repeat the (calculate fields) and 
(calculate theset and labels) code, which I'm trying to avoid for obvious 
reasons.

In my special case, I provide the records to the new IS_IN_DB subclass, in 
which case I only would need to override/extend the new get_records method, 
without duplicating any code.

Can I count on this change?, or should I just forget about it?.

Thanks,

   Carlos