It looks nice and the code is very organized. I'm not sure if I would use it 
or who would use it.

Some suggestions on the code:

1) there's a lot of duplicate code that I bet you could reduce. For example, 
all the controllers could be collapsed down into one controller since they 
are all nearly identical.

2) this is a personal preference but indenting with spaces is more common 
among Python programmers

3) also a personal preference but Python programmers tend to write their 
without as many newlines. Just read some other people's code and you will 
see a lot of commonality on when to start a new line, etc.

4) you might want to put the define_tables in db.py which is common. and the 
menus in menu.py.

5) there is a db feature called "auth.signature" which will take care of the 
created_by/modified_by/modified_on. Ise it like this: 
db.define_table('tablename', Field('fieldname'), auth.signature)

6) you should make it so that app/default/index works since that is usually 
where people start.

7) you might want to create your own layout that is different from the 
default web2py look-and-feel

8) if you are going to be making improvements to the service, you might 
consider using version control (Mercurial) and hosting it Google Code or 
Bitbucket


Reply via email to