Hi,

One of the recent changes in Storage.__setattr__ is [ if value == None: ].

Shouldn't we always use "is" instead of "==" for all singletons like None?.

For reference in the particular case of Storage.__setattr__ with a Row 
object as the value (using the current "==" instead of "is"), it will 
internally execute the Row.__eq__ function, which itself calls 
"self.as_dict()" via try, thus doing some unnecessary processing which 
affects performance.

Please correct me if I'm wrong - thanks,

   Carlos

Reply via email to