very good catch!

On May 31, 10:07 am, Carlos <[email protected]> wrote:
> Hi,
>
> I believe there's a bug in dal.py (latest trunk), lines # 4439 and 4440.
>
> Currently ...
>
>             if isinstance(field, Field) and not field.name in fieldnames:
>                 if hasattr(field, '_db'):
>                     field = copy.copy(field)
>                 else:
>                     newfields.append(field)
>                 fieldnames.add(field.name)                
>
> New proposed fix ...
>
>             if isinstance(field, Field) and not field.name in fieldnames:
>                 if hasattr(field, '_db'):
>                     field = copy.copy(field)
>                 newfields.append(field)
>                 fieldnames.add(field.name)                
>
> Must append to newfields regardless if _db or not ... right?.
>
> Thanks,
>
>    Carlos

Reply via email to