At least for me to following is faster when reading...

-        if not headers is None:
+        if headers is None:
+          headers={}
+        else:
            for c in columns:#new implement dict
....

regards

thomas


> I think I found a bug with the headers with the above version, which
> when headers=None generates a unsubscriptable error at line 2061:
>
> if isinstance(headers[colname],dict):
>
> This error can be fixed by the following changes added to line 1966 of
> sqlhtml.py:
>
>         if not headers is None:
>             for c in columns:#new implement dict
>                 if isinstance(headers.get(c, c), dict):
>                     coldict = headers.get(c, c)
>                     attrcol = dict()
>                     if coldict['width']!="":
>                         attrcol.update(_width=coldict['width'])
>                     if coldict['class']!="":
>                         attrcol.update(_class=coldict['class'])
>                     row.append(TH(coldict['label'],**attrcol))
>                 elif orderby:
>                     row.append(TH(A(headers.get(c, c),
>                                     _href=th_link+'?orderby=' + c)))
>                 else:
>                     row.append(TH(headers.get(c, c)))
>
>             if extracolumns:#new implement dict
>                 for c in extracolumns:
>                     attrcol = dict()
>                     if c['width']!="":
>                         attrcol.update(_width=c['width'])
>                     if c['class']!="":
>                         attrcol.update(_class=c['class'])
>                     row.append(TH(c['label'],**attrcol))
>
>             components.append(THEAD(TR(*row)))
> +        else:
> +          headers={}
>
> Cheers
> Calvin

Reply via email to