Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 54da8cdbc53dd78bf1cb5bc83f0a8b4e49ca2409
https://github.com/WebKit/WebKit/commit/54da8cdbc53dd78bf1cb5bc83f0a8b4e49ca2409
Author: Alan Baradlay <za...@apple.com>
Date: 2025-08-25 (Mon, 25 Aug 2025)
Changed paths:
A
LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/align-out-of-flow-only-content-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/align-out-of-flow-only-content-ref.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/align-out-of-flow-only-content.html
M Source/WebCore/rendering/RenderBlockFlow.cpp
Log Message:
-----------
[align-content] out-of-flow box with no sibling ignores align-content
https://bugs.webkit.org/show_bug.cgi?id=297828
Reviewed by Antti Koivisto.
Inline content mixed with out-of-flow boxes generate IFC (inlineLayout()) to
not only size and position inline boxes but also compute the static position
for those out-of-flow boxes.
Now in case of a single out-of-flow box, we still need to compute the static
position
but when hasSimpleOutOfFlowContentOnly is true, we don't create the IFC object
anymore (fast path).
RenderBlockFlow::shiftForAlignContent aligns the boxes by either calling
shiftLinesBy on IFC (and svg) or moving the _block_ child boxes when
!childrenInline().
The logic here misses the "single out-of-flow box with fast path" case, where
childrenInline() is true but there's no IFC (or svg) inline object to call.
Let's re-shuffle the conditions in shiftForAlignContent to cover all cases.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/align-out-of-flow-only-content-expected.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/align-out-of-flow-only-content-ref.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/align-out-of-flow-only-content.html:
Added.
* Source/WebCore/rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::shiftForAlignContent):
Canonical link: https://commits.webkit.org/299107@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
