Branch: refs/heads/webkitglib/2.50
Home: https://github.com/WebKit/WebKit
Commit: 9747fec076ae372885253ada9afdf862e1486c98
https://github.com/WebKit/WebKit/commit/9747fec076ae372885253ada9afdf862e1486c98
Author: Antoine Quint <grao...@webkit.org>
Date: 2025-08-26 (Tue, 26 Aug 2025)
Changed paths:
M LayoutTests/platform/ios/TestExpectations
M LayoutTests/platform/mac-wk2/TestExpectations
M Source/WebCore/animation/AnimationTimelinesController.cpp
Log Message:
-----------
Cherry-pick 298894@main (8299256761a8).
https://bugs.webkit.org/show_bug.cgi?id=295527
REGRESSION(296903@main): [ Darwin wk2 ]
fast/animation/css-animation-resuming-when-visible-with-style-change2.html is a
flakey text failure
https://bugs.webkit.org/show_bug.cgi?id=295527
rdar://155235713
Reviewed by Tim Nguyen.
We need to make sure we don't clear the cached current time after we've
suspended animations
as that cached current time must remain frozen the entire time animations
are suspended. We now
make sure to do just that in
`AnimationTimelinesController::suspendAnimations()` and add an
assertion that animations aren't suspended in
`AnimationTimelinesController::clearCachedCurrentTime()`.
And so that assertion holds, we switch two lines of code in
`AnimationTimelinesController::resumeAnimations()`
such that the flag tracking whether animations are suspended is cleared
before we call `clearCachedCurrentTime()`.
* LayoutTests/platform/ios/TestExpectations:
* LayoutTests/platform/mac-wk2/TestExpectations:
* Source/WebCore/animation/AnimationTimelinesController.cpp:
(WebCore::AnimationTimelinesController::suspendAnimations):
(WebCore::AnimationTimelinesController::resumeAnimations):
(WebCore::AnimationTimelinesController::clearCachedCurrentTime):
Canonical link: https://commits.webkit.org/298894@main
Canonical link: https://commits.webkit.org/298234.35@webkitglib/2.50
Commit: a04f6b19ff6ec5d234881ace00ba1f7c9ed95405
https://github.com/WebKit/WebKit/commit/a04f6b19ff6ec5d234881ace00ba1f7c9ed95405
Author: Charlie Wolfe <charl...@apple.com>
Date: 2025-08-26 (Tue, 26 Aug 2025)
Changed paths:
M Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebPageProxy.h
Log Message:
-----------
Cherry-pick 298897@main (d47b3493ba2d).
https://bugs.webkit.org/show_bug.cgi?id=297577
REGRESSSION(294690@main): Crash in `WebPageProxy::beginSafeBrowsingCheck`
https://bugs.webkit.org/show_bug.cgi?id=297577
rdar://156557789
Reviewed by Alex Christensen.
This patch fixes several issues in this function:
- showBrowsingWarning was being called on WebPageProxy without a null
check.
- url is not using isolatedCopy() across threads.
- weakThis was never being used.
- RefPtr<API::Navigation> was used in the function parameters.
- WebFrameProxy was only being passed to call isMainFrame(), we should
just pass a bool variable instead.
* Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::beginSafeBrowsingCheck):
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::beginSafeBrowsingCheck):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
* Source/WebKit/UIProcess/WebPageProxy.h:
Canonical link: https://commits.webkit.org/298897@main
Canonical link: https://commits.webkit.org/298234.36@webkitglib/2.50
Compare: https://github.com/WebKit/WebKit/compare/563fe07ddc60...a04f6b19ff6e
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
