Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: d50d95fe9f0eaf7059a1dcb5636745027899b6d5
https://github.com/WebKit/WebKit/commit/d50d95fe9f0eaf7059a1dcb5636745027899b6d5
Author: Alex Christensen <achristen...@apple.com>
Date: 2025-08-27 (Wed, 27 Aug 2025)
Changed paths:
M
LayoutTests/http/wpt/webauthn/public-key-credential-create-failure-local.https.html
M
LayoutTests/http/wpt/webauthn/public-key-credential-create-success-local.https.html
M Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl
M Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp
M Tools/WebKitTestRunner/InjectedBundle/TestRunner.h
M Tools/WebKitTestRunner/TestController.cpp
M Tools/WebKitTestRunner/TestController.h
M Tools/WebKitTestRunner/TestInvocation.cpp
Log Message:
-----------
Begin mass migration from TestRunner.idl to testRunnerJS
https://bugs.webkit.org/show_bug.cgi?id=297973
rdar://159291124
Reviewed by Tim Horton.
There are 3 classes of simple things to migrate. This begins their migration.
1. Notifications implemented with postPageMessage can migrate to just calling
post.
2. Synchronous queries implemented with postSynchronousMessage can migrate to
being
asynchronous queries by adding await to the tests that use them.
3. Asynchronous ueries implemented with postMessageWithAsyncReply can migrate
to either
using post and have the test await the result, or if the callback parameter
model
is to be kept then we can make a little wrapper in testRunnerJS that awaits
the
result of post then calls the callback with it.
This gains implementation experience of some primitives needed to migrate other
applications off of the injected bundle by migrating WebKitTestRunner off the
injected bundle.
*
LayoutTests/http/wpt/webauthn/public-key-credential-create-failure-local.https.html:
*
LayoutTests/http/wpt/webauthn/public-key-credential-create-success-local.https.html:
* Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
* Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::getApplicationManifestThen): Deleted.
(WTR::TestRunner::keyExistsInKeychain): Deleted.
(WTR::TestRunner::waitBeforeFinishingFullscreenExit): Deleted.
(WTR::TestRunner::scrollDuringEnterFullscreen): Deleted.
(WTR::TestRunner::finishFullscreenExit): Deleted.
(WTR::TestRunner::requestExitFullscreenFromUIProcess): Deleted.
* Tools/WebKitTestRunner/InjectedBundle/TestRunner.h:
* Tools/WebKitTestRunner/TestController.cpp:
(WTR::TestController::requestExitFullscreenFromUIProcess):
(WTR::adoptAndCallCompletionHandler):
(WTR::if):
(WTR::CompletionHandler<void):
* Tools/WebKitTestRunner/TestController.h:
* Tools/WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
Canonical link: https://commits.webkit.org/299219@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
