Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 645fdf3e81568d4e0e8a0bd7994fa4aa14179e5b
https://github.com/WebKit/WebKit/commit/645fdf3e81568d4e0e8a0bd7994fa4aa14179e5b
Author: Razvan Caliman <rcali...@apple.com>
Date: 2025-08-27 (Wed, 27 Aug 2025)
Changed paths:
M Source/WebInspectorUI/UserInterface/Views/SpreadsheetTextField.js
Log Message:
-----------
Web Inspector: Styles: Lazily create completion suggestions view
https://bugs.webkit.org/show_bug.cgi?id=297911
rdar://159196049
Reviewed by Devin Rousso and BJ Burg.
Initialize the completion suggestions view and suggestion hint element
only when first entering edit mode to avoid creating unused objects.
`WI.SpreadsheetTextField.prototype.discardCompletion()` is the only
method that can get called without ever entering edit mode. It happens via:
`WI.SpreadsheetStyleProperty.prototype.detach()` ->
`WI.SpreadsheetTextField.prototype.detach()`
* Source/WebInspectorUI/UserInterface/Views/SpreadsheetTextField.js:
(WI.SpreadsheetTextField):
(WI.SpreadsheetTextField.prototype.get suggestionHint):
(WI.SpreadsheetTextField.prototype.startEditing):
(WI.SpreadsheetTextField.prototype.discardCompletion):
Canonical link: https://commits.webkit.org/299221@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
