Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7afa0e46c1b491b4c8f48a5bc01b4445dba9b30b https://github.com/WebKit/WebKit/commit/7afa0e46c1b491b4c8f48a5bc01b4445dba9b30b Author: Dana Estra <des...@apple.com> Date: 2025-08-28 (Thu, 28 Aug 2025)
Changed paths: M Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp M Source/WebCore/page/CaptionUserPreferencesMediaAF.h Log Message: ----------- Simplify calls to CaptionUserPreferencesMediaAF::hasNullCaptionProfile() https://bugs.webkit.org/show_bug.cgi?id=298056 rdar://159385038 Reviewed by Eric Carlson. This is a follow-up to https://github.com/WebKit/WebKit/commit/e8284c96eb6205fa9ad7a78207394d1ef2984b9c. Instead of calling hasNullCaptionProfile() in every place we call testingMode(), we should just override testingMode() and call hasNullCaptionProfile() from there. * Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp: (WebCore::CaptionUserPreferencesMediaAF::captionDisplayMode const): (WebCore::CaptionUserPreferencesMediaAF::setCaptionDisplayMode): (WebCore::CaptionUserPreferencesMediaAF::userPrefersCaptions const): (WebCore::CaptionUserPreferencesMediaAF::userPrefersSubtitles const): (WebCore::CaptionUserPreferencesMediaAF::userPrefersTextDescriptions const): (WebCore::CaptionUserPreferencesMediaAF::testingMode const): (WebCore::CaptionUserPreferencesMediaAF::captionFontSizeScaleAndImportance const): (WebCore::CaptionUserPreferencesMediaAF::setPreferredLanguage): (WebCore::CaptionUserPreferencesMediaAF::preferredLanguages const): (WebCore::CaptionUserPreferencesMediaAF::setPreferredAudioCharacteristic): (WebCore::CaptionUserPreferencesMediaAF::preferredAudioCharacteristics const): (WebCore::CaptionUserPreferencesMediaAF::captionsStyleSheetOverride const): * Source/WebCore/page/CaptionUserPreferencesMediaAF.h: Canonical link: https://commits.webkit.org/299287@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes