Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1a312fad1c168e8099434b3a5443247030ddabf4
      
https://github.com/WebKit/WebKit/commit/1a312fad1c168e8099434b3a5443247030ddabf4
  Author: Alex Christensen <achristen...@apple.com>
  Date:   2025-08-28 (Thu, 28 Aug 2025)

  Changed paths:
    M Source/WebCore/bindings/js/DOMWrapperWorld.h
    M Source/WebCore/page/UserMessageHandler.cpp
    M Source/WebCore/page/UserMessageHandler.h
    M Source/WebCore/page/UserMessageHandler.idl
    M Source/WebCore/page/UserMessageHandlerDescriptor.h
    M Source/WebKit/Shared/WebPageCreationParameters.h
    M Source/WebKit/Shared/WebPageCreationParameters.serialization.in
    M Source/WebKit/UIProcess/API/APIPageConfiguration.cpp
    M Source/WebKit/UIProcess/API/APIPageConfiguration.h
    M Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm
    M Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h
    M Source/WebKit/UIProcess/UserContent/WebUserContentControllerProxy.cpp
    M Source/WebKit/UIProcess/UserContent/WebUserContentControllerProxy.h
    M 
Source/WebKit/UIProcess/UserContent/WebUserContentControllerProxy.messages.in
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Source/WebKit/WebProcess/InjectedBundle/InjectedBundleScriptWorld.cpp
    M Source/WebKit/WebProcess/InjectedBundle/InjectedBundleScriptWorld.h
    M Source/WebKit/WebProcess/UserContent/WebUserContentController.cpp
    M Source/WebKit/WebProcess/WebPage/WebPage.cpp
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm

  Log Message:
  -----------
  Add UserMessageHandler.postLegacySynchronousMessage for Music
https://bugs.webkit.org/show_bug.cgi?id=298069
rdar://159397219

Reviewed by Tim Horton.

Music has a vast catalog of static third party web content from the iTunes days 
that
they can't update, and it relies on JS synchonously controlling the application.
It has been migrated from WebKitLegacy to multi-process WebKit, but it still 
relies
on WKBundlePostSynchronousMessage to achieve this functionality.  On Windows, it
uses HostObjectSyncProxy.  This may seem like it is adding a new synchronous 
message,
but it does so only for Music on macOS, and it provides a path towards removing 
their
use of WKBundlePostSynchronousMessage and the injected bundle in general.

* Source/WebCore/bindings/js/DOMWrapperWorld.h:
(WebCore::DOMWrapperWorld::setAllowPostLegacySynchronousMessage):
(WebCore::DOMWrapperWorld::allowPostLegacySynchronousMessage const):
* Source/WebCore/page/UserMessageHandler.cpp:
(WebCore::UserMessageHandler::postLegacySynchronousMessage):
* Source/WebCore/page/UserMessageHandler.h:
* Source/WebCore/page/UserMessageHandler.idl:
* Source/WebCore/page/UserMessageHandlerDescriptor.h:
* Source/WebKit/Shared/WebPageCreationParameters.h:
* Source/WebKit/Shared/WebPageCreationParameters.serialization.in:
* Source/WebKit/UIProcess/API/APIPageConfiguration.cpp:
(API::PageConfiguration::setAllowPostingLegacySynchronousMessages):
(API::PageConfiguration::allowPostingLegacySynchronousMessages const):
* Source/WebKit/UIProcess/API/APIPageConfiguration.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration _setAllowPostingLegacySynchronousMessages:]):
(-[WKWebViewConfiguration _allowPostingLegacySynchronousMessages]):
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
* Source/WebKit/UIProcess/UserContent/WebUserContentControllerProxy.cpp:
(WebKit::WebUserContentControllerProxy::didPostLegacySynchronousMessage):
* Source/WebKit/UIProcess/UserContent/WebUserContentControllerProxy.h:
* Source/WebKit/UIProcess/UserContent/WebUserContentControllerProxy.messages.in:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::creationParameters):
* Source/WebKit/WebProcess/InjectedBundle/InjectedBundleScriptWorld.cpp:
(WebKit::InjectedBundleScriptWorld::setAllowPostingLegacySynchronousMessages):
* Source/WebKit/WebProcess/InjectedBundle/InjectedBundleScriptWorld.h:
* Source/WebKit/WebProcess/UserContent/WebUserContentController.cpp:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::m_textAnimationController):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
(-[TestScriptMessageHandlerWithReply 
userContentController:didReceiveScriptMessage:replyHandler:]):
(LegacySynchronousMessages)):

Canonical link: https://commits.webkit.org/299303@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to