Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: eacdac1d58d8a1662211a1d3de88978645e48750
https://github.com/WebKit/WebKit/commit/eacdac1d58d8a1662211a1d3de88978645e48750
Author: David Kilzer <ddkil...@apple.com>
Date: 2025-08-29 (Fri, 29 Aug 2025)
Changed paths:
M Source/WTF/wtf/Assertions.h
M Tools/TestWebKitAPI/Tests/WebKitCocoa/SOAuthorizationTests.mm
Log Message:
-----------
Remove ALLOW_NONLITERAL_FORMAT_BEGIN/END macros for generateHtml() in
SOAuthorizationTests.mm
<https://bugs.webkit.org/show_bug.cgi?id=298073>
<rdar://159403033>
Reviewed by Darin Adler.
* Source/WTF/wtf/Assertions.h:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/SOAuthorizationTests.mm:
- Change static C-string declarations from `const char*` to
`constexpr auto` so they may be used as format strings.
(generateHtml): Rename to generateHTML().
(generateHTML):
- Reduce argument list to template and one String.
- Add WTF_ATTRIBUTE_PRINTF_MATCHES() macro.
(generateOpenerHTML): Add.
- Make a copy of generateHtml() that uses a three-placeholder format
string for use with `openerTemplate`.
- Add WTF_ATTRIBUTE_PRINTF_MATCHES() macro.
- Move `ALLOW_NONLITERAL_FORMAT_BEGIN`/`END` macros outside of both
functions as a workaround for older Apple OSes that don't support the
`format_matches` attribute.
(TestWebKitAPI::TEST(SOAuthorizationPopUp, NoInterceptions)):
(TestWebKitAPI::TEST(SOAuthorizationPopUp, NoInterceptionsSubFrame)):
(TestWebKitAPI::TEST(SOAuthorizationPopUp, InterceptionError)):
(TestWebKitAPI::TEST(SOAuthorizationPopUp, InterceptionCancel)):
(TestWebKitAPI::TEST(SOAuthorizationPopUp, InterceptionSucceedCloseByItself)):
(TestWebKitAPI::TEST(SOAuthorizationPopUp, InterceptionSucceedCloseByParent)):
(TestWebKitAPI::TEST(SOAuthorizationPopUp, InterceptionSucceedCloseByWebKit)):
(TestWebKitAPI::TEST(SOAuthorizationPopUp,
InterceptionSucceedWithOtherHttpStatusCode)):
(TestWebKitAPI::TEST(SOAuthorizationPopUp, InterceptionSucceedWithCookie)):
(TestWebKitAPI::TEST(SOAuthorizationPopUp, InterceptionSucceedTwice)):
(TestWebKitAPI::TEST(SOAuthorizationPopUp,
InterceptionSucceedSuppressActiveSession)):
(TestWebKitAPI::TEST(SOAuthorizationPopUp,
InterceptionSucceedNewWindowNavigation)):
(TestWebKitAPI::TEST(SOAuthorizationPopUp, AuthorizationOptions)):
(TestWebKitAPI::TEST(SOAuthorizationPopUp, SOAuthorizationLoadPolicyIgnore)):
(TestWebKitAPI::TEST(SOAuthorizationPopUp,
SOAuthorizationLoadPolicyAllowAsync)):
(TestWebKitAPI::TEST(SOAuthorizationPopUp,
SOAuthorizationLoadPolicyIgnoreAsync)):
(TestWebKitAPI::TEST(SOAuthorizationSubFrame, NoInterceptions)):
(TestWebKitAPI::TEST(SOAuthorizationSubFrame,
NoInterceptionsNonAppleFirstPartyMainFrame)):
(TestWebKitAPI::TEST(SOAuthorizationSubFrame, InterceptionError)):
(TestWebKitAPI::TEST(SOAuthorizationSubFrame, InterceptionCancel)):
(TestWebKitAPI::TEST(SOAuthorizationSubFrame, InterceptionSuccess)):
(TestWebKitAPI::TEST(SOAuthorizationSubFrame,
InterceptionSucceedWithOtherHttpStatusCode)):
(TestWebKitAPI::TEST(SOAuthorizationSubFrame, InterceptionSucceedWithCookie)):
(TestWebKitAPI::TEST(SOAuthorizationSubFrame,
InterceptionSucceedWithCookieButCSPDeny)):
(TestWebKitAPI::TEST(SOAuthorizationSubFrame,
InterceptionSucceedWithCookieButXFrameDeny)):
(TestWebKitAPI::TEST(SOAuthorizationSubFrame, InterceptionSuccessTwice)):
(TestWebKitAPI::TEST(SOAuthorizationSubFrame, AuthorizationOptions)):
(TestWebKitAPI::TEST(SOAuthorizationSubFrame, SOAuthorizationLoadPolicyIgnore)):
(TestWebKitAPI::TEST(SOAuthorizationSubFrame,
SOAuthorizationLoadPolicyAllowAsync)):
(TestWebKitAPI::TEST(SOAuthorizationSubFrame,
SOAuthorizationLoadPolicyIgnoreAsync)):
(TestWebKitAPI::TEST(SOAuthorizationSubFrame, InterceptionErrorWithReferrer)):
(TestWebKitAPI::TEST(SOAuthorizationSubFrame, InterceptionErrorMessageOrder)):
(TestWebKitAPI::TEST(SOAuthorizationSubFrame, InterceptionSuccessMessageOrder)):
- Switch from calling `generateHtml(openerTemplate, ...)` to calling
`generateOpenerHTML(openerTemplate, ...)`.
- Rename `generateHtml()` to `generateHTML()`.
Canonical link: https://commits.webkit.org/299352@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
