Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ed86232a3c29841b3009f4fd03ada9cfee76cfb1
https://github.com/WebKit/WebKit/commit/ed86232a3c29841b3009f4fd03ada9cfee76cfb1
Author: Sosuke Suzuki <sos...@bun.sh>
Date: 2025-08-30 (Sat, 30 Aug 2025)
Changed paths:
M JSTests/stress/sampling-profiler-wasm-name-section.js
M JSTests/stress/sampling-profiler-wasm.js
M JSTests/wasm/function-tests/nameSection.js
M JSTests/wasm/function-tests/stack-overflow.js
M JSTests/wasm/function-tests/stack-trace.js
M JSTests/wasm/stress/simple-inline-stacktrace-2.js
M JSTests/wasm/stress/simple-inline-stacktrace-with-catch-2.js
M JSTests/wasm/stress/simple-inline-stacktrace-with-catch.js
M JSTests/wasm/stress/simple-inline-stacktrace.js
M Source/JavaScriptCore/runtime/StackFrame.cpp
M Source/JavaScriptCore/wasm/WasmIndexOrName.h
M Source/JavaScriptCore/wasm/WasmNameSection.h
Log Message:
-----------
[JSC] Remove `<?>` from wasm function stack trace when
`useEagerWasmModuleHashing` is disabled
https://bugs.webkit.org/show_bug.cgi?id=297880
Reviewed by Yusuke Suzuki.
Currently, Wasm function stack traces contain "<?>" as follows:
run@<?>:wasm-function
This is a placeholder for the module hash that is only displayed when the
useEagerWasmModuleHashing option (disabled by default) is enabled. In other
words, when this option is disabled, it has no meaning.
This patch fixes Wasm stack traces to not include "<?>" when
useEagerWasmModuleHashing is disabled.
* JSTests/stress/sampling-profiler-wasm-name-section.js:
(platformSupportsSamplingProfiler.vm.isWasmSupported):
* JSTests/stress/sampling-profiler-wasm.js:
(platformSupportsSamplingProfiler.vm.isWasmSupported):
* JSTests/wasm/function-tests/nameSection.js:
* JSTests/wasm/function-tests/stack-overflow.js:
(import.Builder.from.string_appeared_here.import.as.assert.from.string_appeared_here.assertOverflows):
(assertOverflows.assertThrows):
(assertOverflows):
* JSTests/wasm/function-tests/stack-trace.js:
* JSTests/wasm/stress/simple-inline-stacktrace-2.js:
(i.catch):
* JSTests/wasm/stress/simple-inline-stacktrace-with-catch-2.js:
(let.readMem.new.Int32Array.wasm_instance.exports.mem.buffer.const.iterCount.9.verifyStack):
(): Deleted.
* JSTests/wasm/stress/simple-inline-stacktrace-with-catch.js:
(let.readMem.new.Int32Array.wasm_instance.exports.mem.buffer.const.iterCount.9.verifyStack):
(): Deleted.
* JSTests/wasm/stress/simple-inline-stacktrace.js:
(i.catch):
* Source/JavaScriptCore/runtime/StackFrame.cpp:
(JSC::StackFrame::sourceURL const):
(JSC::StackFrame::sourceURLStripped const):
* Source/JavaScriptCore/wasm/WasmIndexOrName.h:
(JSC::Wasm::IndexOrName::moduleName const):
* Source/JavaScriptCore/wasm/WasmNameSection.h:
(JSC::Wasm::NameSection::NameSection):
Canonical link: https://commits.webkit.org/299359@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
