Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: fb7ca044092d1152852a83c4d8f156f672357759
https://github.com/WebKit/WebKit/commit/fb7ca044092d1152852a83c4d8f156f672357759
Author: Ryan Reno <rr...@apple.com>
Date: 2025-08-30 (Sat, 30 Aug 2025)
Changed paths:
M
Source/WebCore/SaferCPPExpectations/UncountedLambdaCapturesCheckerExpectations
M Source/WebCore/dom/BroadcastChannel.cpp
M Source/WebCore/dom/Document.cpp
M Source/WebCore/dom/Subscriber.cpp
M Source/WebCore/dom/Subscriber.h
Log Message:
-----------
Fix some Safer C++ lambda capture issues in WebCore/dom
https://bugs.webkit.org/show_bug.cgi?id=298127
rdar://159475468
Reviewed by Geoffrey Garen.
Apply SaferCPP rules for lambda captures to some files in WebCore/dom.
*
Source/WebCore/SaferCPPExpectations/UncountedLambdaCapturesCheckerExpectations:
* Source/WebCore/dom/BroadcastChannel.cpp:
* Source/WebCore/dom/Document.cpp:
This one is actually safe for the Document but passing a Ref to the Document
in to the lambda helps us sidestep any problems with the Settings raw
pointer
being passed into functions not necessarily visible from this scope.
* Source/WebCore/dom/Subscriber.cpp:
We may need to create a RefPtr if we run the AbortSignal's algorithm
installed in Subscriber::followSignal immediately during object
construction. In that case we will hit a debug assert in RefCounted since
we haven't finished adoption yet. We can safely relax the adoption
requirement
here since we aren't at risk of forgetting to adopt the reference.
Canonical link: https://commits.webkit.org/299365@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
