Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 202477fe85b4db3ca4477237f6321ee444325fc4
https://github.com/WebKit/WebKit/commit/202477fe85b4db3ca4477237f6321ee444325fc4
Author: Elijah Sawyers <esawy...@apple.com>
Date: 2025-09-02 (Tue, 02 Sep 2025)
Changed paths:
M Source/WebCore/en.lproj/Localizable.strings
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm
M
Source/WebKit/UIProcess/Extensions/Cocoa/_WKWebExtensionDeclarativeNetRequestRule.mm
M
Source/WebKit/UIProcess/Extensions/Cocoa/_WKWebExtensionDeclarativeNetRequestTranslator.mm
M
Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIDeclarativeNetRequest.mm
Log Message:
-----------
dNR: make sure every rule ID is unique
https://bugs.webkit.org/show_bug.cgi?id=298070
rdar://72159785
Reviewed by Brian Weinstein.
This simple patch reports an error when a static dNR ruleset contains a
duplicate identifier. It's
important that we do this so that developers are aware that they might be
getting incorrect
information from onRuleMatchedDebug.
The error is surfaced in Safari's extensions preferences pane.
* Source/WebCore/en.lproj/Localizable.strings:
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm:
(WebKit::WebExtensionContext::compileDeclarativeNetRequestRules):
*
Source/WebKit/UIProcess/Extensions/Cocoa/_WKWebExtensionDeclarativeNetRequestRule.mm:
*
Source/WebKit/UIProcess/Extensions/Cocoa/_WKWebExtensionDeclarativeNetRequestTranslator.mm:
(WebKit::for):
*
Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIDeclarativeNetRequest.mm:
(TestWebKitAPI::TEST(WKWebExtensionAPIDeclarativeNetRequest,
DuplicatedRuleIDs)):
Canonical link: https://commits.webkit.org/299456@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
