Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: c51356d573bee3e638d384c19944d4f857ec6245
https://github.com/WebKit/WebKit/commit/c51356d573bee3e638d384c19944d4f857ec6245
Author: Ryan Haddad <[email protected]>
Date: 2026-08-18 (Tue, 18 Aug 2026)
Changed paths:
M Tools/CISupport/ews-build/steps.py
M Tools/CISupport/ews-build/steps_unittest.py
Log Message:
-----------
[EWS] macOS-Sequoia-Release-Site-Isolation-Tests-EWS does not retry tests
before reporting results
https://bugs.webkit.org/show_bug.cgi?id=319725
rdar://182558497
Reviewed by Aakash Jain.
The Site-Isolation-Tests EWS queue reported a change as failing after a single
test run, skipping
the retry ladder that every other layout-test queue uses to avoid blaming a
change for flaky or
pre-existing failures.
The queue can reuse the existing ladder as-is. Both the first run and the
re-run need the site-isolation
flavor, since each consults results-db and can pass the build early when every
failure is already known.
Without it the re-run would query regular WK2 history for this queue, which
could mark a
site-isolation-specific regression as pre-existing and hide it.
* Tools/CISupport/ews-build/steps.py:
(RunWebKitTests.rerun_step): Added, so a queue can substitute its own re-run
step.
(RunWebKitTests.evaluateCommand): Use rerun_step().
(RunWebKitTestsInSiteIsolationMode.doStepIf):
(SiteIsolationResultsDBMixin): Added, holding the site-isolation results-db
flavor and reports_to_results_db
for both site-isolation steps.
(SiteIsolationResultsDBMixin.results_db_query_configuration): Moved from
RunWebKitTestsEWSSiteIsolation.
(RunWebKitTestsEWSSiteIsolation): Moved below ReRunWebKitTests so it can
reference the re-run step.
Removed the single-run evaluateCommand and the filter_failures_using_results_db
override that duplicated
the base implementation.
(RunWebKitTestsEWSSiteIsolation.rerun_step):
(ReRunWebKitTestsEWSSiteIsolation): Added, the re-run step for this queue.
(RunWebKitTestsEWSSiteIsolation.results_db_query_configuration): Deleted.
(RunWebKitTestsEWSSiteIsolation.filter_failures_using_results_db): Deleted.
(RunWebKitTestsEWSSiteIsolation.evaluateCommand): Deleted.
* Tools/CISupport/ews-build/steps_unittest.py: Add unit tests.
Canonical link: https://commits.webkit.org/319404@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
