Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: a38bcdb6196c9e935c905d19b4a9c323bf296eae
https://github.com/WebKit/WebKit/commit/a38bcdb6196c9e935c905d19b4a9c323bf296eae
Author: Zak Ridouh <[email protected]>
Date: 2026-08-19 (Wed, 19 Aug 2026)
Changed paths:
M Source/WebCore/Headers.cmake
M Source/WebKit/PlatformCocoa.cmake
M Source/WebKit/UIProcess/API/Cocoa/WKBackForwardListItemInternal.h
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionControllerCocoa.mm
M Source/cmake/OptionsCocoa.cmake
Log Message:
-----------
[CMake] Fix the iOS simulator build
https://bugs.webkit.org/show_bug.cgi?id=322130
rdar://185356757
Reviewed by Elliott Williams.
Every failure was a place where the CMake build disagreed with Xcode:
- ENABLE_WEBDRIVER_TOUCH_INTERACTIONS was never enabled for the iOS family,
so cmakeconfig.h set it to 0 and overrode PlatformEnableCocoa.h. Mirror
the Platform.h value for now; the follow-up that derives the generators'
feature defines from Platform.h will make this unnecessary.
- Headers.cmake exported StyleComputedStyleProperties+ConstructionInlines.h,
whose own include is not exported, so the WebCore_Private module failed to
build. Xcode does not export it either.
- The stripped WebKit_Internal modulemap was missing
WKBackForwardListItemInternal, which WebPage+BackForwardList.swift imports.
Gate that header's C++ section on WK_SUPPORTS_SWIFT_OBJCXX_INTEROP so Swift
sees only the Objective-C part, as the other headers in that modulemap do.
- WebPage+SPI.swift and WebView+ViewportConfiguration.swift were missing from
the Swift source lists.
- WebKitSwift and _WebKit_SwiftUI never got WebKit's platform-swift-args.resp,
so WTF_PLATFORM_IOS_FAMILY was undefined and both compiled their AppKit
branch. Xcode passes the equivalent file to every target in the project
from Base.xcconfig.
- PowerLog.framework is not in the iOS SDKs; link it on macOS only, matching
WK_POWERLOG_LDFLAGS_macosx in WebKit.xcconfig.
Also wrap a deprecated NSDistributedNotificationCenter call in
ALLOW_DEPRECATED_DECLARATIONS. The replacement needs an audience and an
entitlement, so that is left as a FIXME.
* Source/WebCore/Headers.cmake:
* Source/WebKit/PlatformCocoa.cmake:
* Source/WebKit/UIProcess/API/Cocoa/WKBackForwardListItemInternal.h:
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionControllerCocoa.mm:
(WebKit::WebExtensionController::removeData):
* Source/cmake/OptionsCocoa.cmake:
Canonical link: https://commits.webkit.org/319505@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
