Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: e322518ca67badebab1e4aacd5adb84b6f6eaa47
https://github.com/WebKit/WebKit/commit/e322518ca67badebab1e4aacd5adb84b6f6eaa47
Author: Basuke Suzuki <[email protected]>
Date: 2026-08-20 (Thu, 20 Aug 2026)
Changed paths:
M Source/cmake/OptionsCocoa.cmake
Log Message:
-----------
[CMake][Cocoa] ENGINEERING_BUILD is never defined, disabling JSC restricted
options in all CMake builds
https://bugs.webkit.org/show_bug.cgi?id=322112
rdar://185330809
Reviewed by Elliott Williams.
Configurations/CommonBase.xcconfig defines ENGINEERING_BUILD=1 for Debug and
Release and 0 for
Production, and JSC gates Config::enableRestrictedOptions() on it. Nothing
under Source/cmake/
defines the macro, so JSC Restricted options (useDollarVM, functionOverrides,
dumpJITMemoryPath,
validateAbstractInterpreterState, ...) cannot be set through JSC_* environment
variables in a CMake
build. The jsc shell and WebKitTestRunner reach into JSC directly and are
unaffected; the broken
case is running MiniBrowser or another client against a CMake-built WebKit.
Expose ENGINEERING_BUILD from OptionsCocoa.cmake, unconditionally. CMake does
not build the Cocoa
port for Production, so every configuration it can produce today corresponds to
an Xcode
configuration where the macro is 1. The FIXME marks this as the line to revisit
if that changes.
No new tests (build configuration change, no behavior change in shipping
builds).
* Source/cmake/OptionsCocoa.cmake:
Canonical link: https://commits.webkit.org/319565@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
